Add support for command GEOPOS #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lucifercr07, I have made a draft PR for the issue. I will update it with all the changes in the next few days. |
|
@lucifercr07, can you please review the PR? After @arpitbbhayani's recent pushes, the tests are failing now. Can you please give me some pointers on how to adapt the code to the latest master branch? |
@helios2003 will check once. Thanks. |
|
@lucifercr07, any updates on the review process? |
lucifercr07
approved these changes
Dec 9, 2024
| expected: []interface{}{[]interface{}{nil}}, | ||
| }, | ||
| { | ||
| name: "GEOPOS for non-existing index", |
There was a problem hiding this comment.
Shall we add a test for below case?
redis> SET k1 v1
"OK"
redis> GEOPOS k1 v1
(error) WRONGTYPE Operation against a key holding the wrong kind of value
|
@lucifercr07, I have made the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to resolve issue #1249
Tasks