Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaqone flavored AAPS: Dexcom G7 integration, latest BG fix, AutoIFS #8

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

khskekec
Copy link

@khskekec khskekec commented Nov 8, 2022

No description provided.

@mxsrm
Copy link

mxsrm commented Nov 15, 2022

This combination leads to an unpleasant bug with SMB:

In the normal AAPS it is possible to enable "SMB always on" and disable "SMB on high temp targets" at the same time. With these patches, however, SMB is then simply always on anyway and emits.

I like to make a temp target of 105mg/dl if I don't want to have SMB for a certain time but only temp rates. This is therefore impossible.

Possibly SMB is also permanently active regardless of the settings, that I have not explicitly tested.

@khskekec
Copy link
Author

Hey @blaqone,

can you confirm this and are you aware of this?

@mxsrm Is it possible for you to just check this behaviour also in the master branch of this repo. This would limit the research to autoISF.

@mxsrm
Copy link

mxsrm commented Nov 15, 2022

@khskekec
I will try to do that tomorrow.

@blaqone
Copy link
Collaborator

blaqone commented Nov 15, 2022

Hi @mxsrm,
it looks like you are right. I figured out the error:
The original author of the autoifs integration @T-o-b-i-a-s made a mistake when merging the latest autoifs verion 2.2.7 to the latest AAPS master 3.0.1.3. The switch (enableSMB_EvenOn_OddOff) to enable and disable SMBs is missing. Whereas here ( https://github.com/T-o-b-i-a-s/AndroidAPS/blob/3.1.0.2-ai2.2.7/app/src/main/java/info/nightscout/androidaps/plugins/aps/openAPSSMB/DetermineBasalAdapterSMBJS.kt ) the switch is still there ...

So it got lost in the process of switching from AAPS master branch 3.0.1.2 to .3.
@khskekec will try to change it, but I also msged @T-o-b-i-a-s to correct the mistake.

@khskekec
Copy link
Author

Hi @blaqone and @mxsrm,

i just merged the last changes from Tobias: blaqone-final...T-o-b-i-a-s:AndroidAPS:3.1.0.3-ai2.2.7.

Let me know if you face any problems.

@mxsrm
Copy link

mxsrm commented Nov 29, 2022

Seems to have fixed the bug, thank you!

khskekec pushed a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants