Update files to 0.4.0 plus some cleanup #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
southeo
reviewed
Oct 16, 2024
| ods:,MachineAnnotationService,Machine Annotation Service,A machine agent which will perform an action on the Digital Object potentially resulting in a new annotation on the object,,,,http://www.w3.org/2000/01/rdf-schema#Class,ods:MachineAnnotationService,True,True,MachineAnnotationService,http://rs.dissco.eu/opends/terms/,http://rs.dissco.eu/opends/terms/MachineAnnotationService,ods:MachineAnnotationService,, | ||
| schema:,schema:identifier,Identifier,Handle of the Machine Annotation Service,,,https://hdl.handle.net/20.5000.1025/XXX-XXX-XXX| https://hdl.handle.net/20.5000.1025/JH1-C37-E7F,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:MachineAnnotationService,True,False,MachineAnnotationService.identifier,http://schema.org/,http://schema.org/identifier,schema:identifier,string, | ||
| ods:,ods:fdoType,Fdo Type,The DOI to the FDO type of the object,,,https://doi.org/21.T11148/417a4f472f60f7974c12,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:MachineAnnotationService,True,False,MachineAnnotationService.fdoType,http://rs.dissco.eu/opends/terms/,http://rs.dissco.eu/opends/terms/fdoType,ods:fdoType,string, | ||
| ods:,ods:status,Status,"The status of the Digital Object. A digital object can be in ods:Draft, when it is not published yet. ods:Active when it is published and the object is active and ods:Tombstone which means the object has been archived.",,,,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:MachineAnnotationService,False,False,MachineAnnotationService.status,http://rs.dissco.eu/opends/terms/,http://rs.dissco.eu/opends/terms/status,ods:status,string,Draft| Active| Tombstone |
There was a problem hiding this comment.
The description says: " digital object can be in ods:Draft.. ods:Active...ods:tombstone..." but the enums for this term are Draft | Active | Tombstone, can you align these?
There was a problem hiding this comment.
Oh yeah, we decided to remove the ods: part but I haven't fixed the description. Will do, is probably on all descriptions of this term
| @@ -1,24 +1,35 @@ | |||
| namespace,term_local_name,label,definition,usage,notes,examples,rdf_type,class_name,is_required,is_repeatable,compound_name,namespace_iri,term_iri,term_ns_name,datatype,enum | |||
There was a problem hiding this comment.
as far as I could find, the usage and notes cols aren't used anywhere, maybe remove them?
There was a problem hiding this comment.
hmm yeah but if I remember correctly it uses the column position somewhere so it might mess things up. Would like to keep this for now, if we switch to an ontology we could start using these things.
| dcterms:,dcterms:issued,Issued,The date and time when the annotation was generated. Generated is here seen as when the object was stored/indexed. In most case this will be the annotation-processing-service. Following the ISO Date Time Format yyyy-MM-dd'T'HH:mm:ss.SSSXXX,,,2023-09-02T13:31:34.806Z,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:Annotation,True,False,Annotation.issued,http://purl.org/dc/terms/,http://purl.org/dc/terms/issued,dcterms:issued,string, | ||
| as:,as:generator,Generator,Object containing information on who generated the object. Generated is here seen as who stored/indexed the object. In most case this will be the annotation-processing-service. Contains an ods:Agent object.,,,,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:Annotation,True,False,Annotation.generator,http://www.w3.org/ns/activitystreams#,http://www.w3.org/ns/activitystreams#generator,as:generator,object, | ||
| ods:,ods:hasAggregateRating,Has Aggregate Rating,The average rating based on multiple ratings or reviews,,,,http://www.w3.org/2000/01/rdf-schema#Class,ods:Annotation,False,False,Annotation.hasAggregateRating,http://rs.dissco.eu/opends/terms/,http://rs.dissco.eu/opends/terms/hasAggregateRating,ods:hasAggregateRating,object, | ||
| schema:,schema:ratingCount,Rating Count,The count of total number of ratings,,,3,http://www.w3.org/1999/02/22-rdf-syntax-ns#Property,ods:ods:hasAggregateRating,True,False,ods:hasAggregateRating.ratingCount,http://schema.org/,http://schema.org/ratingCount,schema:ratingCount,integer, |
There was a problem hiding this comment.
No corner case, it is a nested class that is already prefixed. Now do a check for the prefix so we don't add it twice.
There was a problem hiding this comment.
(Not on this page but related issue)
In routes.py -> line 427, you name the data mapping resource page "mapping resources" instead of "data mapping resources"
return render_template('resources.html',
headerMarkdown=Markup(marked_text),
sssomRefMarkdown=Markup(marked_sssom),
pageTitle='Mapping Resources ', // Here!
classDiagram=class_diagram,
erDiagram=er_diagram,
title='Mapping Resources', // here too!
slug='data-mapping-resources'
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation pages based on the 0.4.0 version of openDS on https://schemas.dissco.tech
Contains the feedback from the Public Review