Fixes coming from the openDS public review #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDijkema
reviewed
Sep 23, 2024
app/routes.py
Outdated
Comment on lines
479
to
481
| terms['examples'] = terms['examples'].str.replace(r'"', '').replace("'", "").replace("[", "").replace("]", "") | ||
| terms['enum'] = terms['enum'].str.replace(r'"', '').replace("'", "").replace("[", "").replace("]", "") | ||
| terms['definition'] = terms['definition'].str.replace(r'"', '').replace("'", "").replace("[", "").replace("]", "") |
There was a problem hiding this comment.
Maybe make a function out of this as you are repeating the same action three times
There was a problem hiding this comment.
Removed the logic for definition as this is never an array
Comment on lines
+70
to
+80
| <tr> | ||
| <th scope="row">Controlled Vocabulary</th> | ||
| <td> | ||
| <ul class="td-list"> | ||
| {% for item in list1 %} | ||
| <li><span>{{ item }}</span></li> | ||
| {% endfor %} | ||
| </ul> | ||
|
|
||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
Don't know how this should look but often and elements are stored in separate (table rows)
There was a problem hiding this comment.
Hmm took this over from Latimer Core only made some small changes to it. Would like to keep this for now
There was a problem hiding this comment.
I understand, just a generic HTML thing that is possible, but not recommended
southeo
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix the following tickets:
Trying to keep the amount of PR's low, not to unnessecary burden.
But do like to keep an administration on which tickets I got