Add annotation mode #134
Merged
Add annotation mode #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotation target can be set from view (setup). The annotation wizard needs to adapt to the changing annotation target without effecting the original annotation flow.
Save progress with annotation mode, selecting a direct annotation target will always go to step 3
Commit for resolving Sonar Cloud issues
|
southeo
approved these changes
Dec 6, 2024
| * @param annotationTargetType The type of the annotation target, either class or term | ||
| * @param jsonPath The JSON path that targets the class or term | ||
| */ | ||
| const SetAnnotationTarget = (annotationTargetType: 'class' | 'term', jsonPath: string) => { |
There was a problem hiding this comment.
A lot of this seems duplicate from the media.tsx file, do you think you can reuse some code?
There was a problem hiding this comment.
Yeah my initial idea was to include as an utility function, only I am not allowed to use hooks out of React components, hence I chose to do it this way. I could include it at an ever higher level and pass it as props, but its irrelevant for a lot of child components. For now this seemed the best way, but can probably be optimized somehow in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the annotation mode to the Digital Specimen page to allow for direct targeting of properties from the view.
This includes some slight changes and fixes to the annotation wizard in general.