Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Digital Media page #118

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

TomDijkema
Copy link
Collaborator

PR refactors the Digital Media page basics and implements the absolute basics of the page: showing the top bar, ID card, image viewer and digital media list. Digital Media annotations will follow up.

Commit refactors the Digital Media page and implements the absolute basics of the page: showing the top bar, ID card, image viewer and digital media list. Digital Media annotations will follow up.
@TomDijkema TomDijkema requested a review from southeo October 30, 2024 11:04
@TomDijkema TomDijkema self-assigned this Oct 30, 2024
Commit for resolving Sonar Cloud issues
Base automatically changed from UseHTMLLabelInIDCard to main October 30, 2024 12:47
Commit for resolving Sonar Cloud issues
Third commit for resolving Sonar Cloud issues
@TomDijkema
Copy link
Collaborator Author

Not going to fix these Sonar duplication issues as I want to keep these as separate files.

Copy link

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things to fix first but here's an approval bc you deserve it tommo

src/api/digitalMedia/GetDigitalMedia.ts Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@TomDijkema TomDijkema merged commit 9fcf82e into main Nov 4, 2024
1 of 2 checks passed
@TomDijkema TomDijkema deleted the RefactorBasicLayOutDigitalMedia branch November 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants