Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DOI identifier check #76

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Improve DOI identifier check #76

merged 1 commit into from
Dec 4, 2024

Conversation

samleeflang
Copy link
Contributor

  • Check on the 10. for DOIs
  • If the identifier start with DOI but isn't a 10. assume it is a handle

@samleeflang samleeflang requested a review from southeo December 2, 2024 13:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

southeo
southeo approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦫

@samleeflang samleeflang merged commit 8567274 into main Dec 4, 2024
3 checks passed
@samleeflang samleeflang deleted the feature/update-doi-regex branch December 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southeo southeo southeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samleeflang @southeo