Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add objects when not empty #75

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Only add objects when not empty #75

merged 3 commits into from
Nov 25, 2024

Conversation

samleeflang
Copy link
Contributor

This is to ensure it does not just add an empty Object with only the constant @type field. This cleans up a bit of empty information which only bloats the object further

@samleeflang samleeflang requested a review from southeo November 21, 2024 14:52
southeo
southeo previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@samleeflang samleeflang merged commit 7e781fc into main Nov 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southeo southeo southeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samleeflang @southeo