Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitize logic to location meter field #74

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

samleeflang
Copy link
Contributor

  • Use regex to sanitize xxxMeter field. Ingestion shows that there are often some simple issues with it. This logic uses regEx to remove the m. m meter mtr` and a couple of other options from the string. This enables parsing it to double and putting it in the field in a lot of cases.
  • When we cannot parse the field try to add it to a verbatim field when available (for distanceAboveSurface it is not available)

@samleeflang samleeflang requested a review from southeo November 20, 2024 14:26
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.3% Duplication on New Code (required ≤ 3%)
77.78% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕

@samleeflang samleeflang merged commit ece746a into main Nov 25, 2024
1 of 2 checks passed
@samleeflang samleeflang deleted the feature/sanitize-meter branch November 25, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants