Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for chronometricAge #73

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

samleeflang
Copy link
Contributor

  • Add mapping to chronometric age

Difficult to test as no DiSSCo dataset uses the dwca extension nor any of the biocase use the abcdefg fields.
There are lots of improvements to be made but first let's do this default mapping as nobody is using this yet anyway

@samleeflang
Copy link
Contributor Author

Not sure what to do with the test. Can't find any examples on how this is actually used.

@samleeflang samleeflang requested a review from southeo November 20, 2024 13:13
southeo
southeo previously approved these changes Nov 20, 2024
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment not blocking

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)
50.0% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@samleeflang samleeflang merged commit 71264ad into main Nov 20, 2024
1 of 2 checks passed
@samleeflang samleeflang deleted the feature/add-chronometric-age branch November 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants