Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add identifier meta #71

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

samleeflang
Copy link
Contributor

  • Add IdentifierUtils which adds metadata to the identifierObject

@samleeflang samleeflang requested a review from southeo November 19, 2024 13:47
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦚

@Slf4j
public class IdentifierUtils {

private static final Map<List<String>, Triple<DctermsType, String, OdsGupriLevel>> map = getPrefixMap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention? MAP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah lacked imagination, now call it PATTERN_MAP

@samleeflang samleeflang requested a review from southeo November 19, 2024 14:58
Copy link

sonarqubecloud bot commented Nov 19, 2024

Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥧

@samleeflang samleeflang merged commit ea7b558 into feature/iiif-er Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants