-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple agents parsing, eventType, media licenses #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👖
the SetAgent() logic is tricky so nice job. I think you're mutating Lists, though, not ArrayLists, so you probably have to slightly restructure.
src/main/java/eu/dissco/core/translator/terms/BaseDigitalObjectDirector.java
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/utils/AgentsUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/specimen/event/EventType.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/domain/AgenRoleType.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/utils/AgentsUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/utils/AgentsUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/eu/dissco/core/translator/terms/utils/AgentUtilsTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏
Improve creation of Agent object:
Set default EventType to "Collecting Event"
Set recorded by as Collector on the main event
Add two fields to media regarding license