Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple agents parsing, eventType, media licenses #67

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

samleeflang
Copy link
Contributor

Improve creation of Agent object:

  • If value is a resolvable identifier use it as identifier (comment on previous PR)
  • When multiple agents in single field parse them to different agents
    • When equal name and identifier combination assume order is the same
    • When unequal take the list with the most entries

Set default EventType to "Collecting Event"
Set recorded by as Collector on the main event

Add two fields to media regarding license

@samleeflang samleeflang requested a review from southeo November 1, 2024 15:38
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👖
the SetAgent() logic is tricky so nice job. I think you're mutating Lists, though, not ArrayLists, so you probably have to slightly restructure.

@samleeflang samleeflang requested a review from southeo November 5, 2024 10:41
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@samleeflang samleeflang merged commit 8c4f7fe into main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants