Feature/add additional terms #59
Conversation
|
|
Updated to the latest version of the openDS which have now been merged into the openDS repo |
| @@ -172,7 +172,7 @@ | |||
| "under water since 2005" | |||
| ] | |||
| }, | |||
| "georeference": { | |||
| "???:GeoReference": { | |||
There was a problem hiding this comment.
Nope at the moment GeoReference isn't a dwc class but these terms fall beneath Location
https://dwc.tdwg.org/list/#31-index-by-term-name
| ds.withEntityRelationships(assembleDigitalSpecimenEntityRelationships(ds)); | ||
| ds.withIdentifier(assembleIdentifiers(data)); | ||
| ds.withCitation(assembleSpecimenCitations(data, dwc)); | ||
| ds.withEntityRelationship(assembleDigitalSpecimenEntityRelationships(ds)); |
There was a problem hiding this comment.
why change this to singletons? citations, identifiers, and relations are all arrays, so it makes sense for them to be plural imo.
There was a problem hiding this comment.
Yes I know but then we can't use the dwc terms. What we could do is create our own ods:Ocurrences which then contain dwc:Occurrence. ABCD(EFG) uses these kind of structures, but they always felt a bit unnecessary as they add this additional level in between. Might be better though, as the dwc:Occurrence isn't an array. I will create a task for this as it impacts the datamodel.
There was a problem hiding this comment.
Both are needed to comply with MIDS
https://naturalis.atlassian.net/browse/DD-993