Feature/new data model #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplication will remain an issue. The main reason there is duplication is to keep all Terms separate. This helps the overview and allows the implementation of custom logic for terms. The duplication is minimal, a single line per term. However as we have a lot of terms it does add up |
southeo
reviewed
Sep 28, 2023
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Outdated
Show resolved
Hide resolved
src/test/java/eu/dissco/core/translator/terms/specimen/identification/DateIdentifiedTest.java
Outdated
Show resolved
Hide resolved
.../java/eu/dissco/core/translator/terms/specimen/identification/taxonomy/SpecimenNameTest.java
Outdated
Show resolved
Hide resolved
src/test/java/eu/dissco/core/translator/terms/specimen/occurence/OrganismQuantityTypeTest.java
Show resolved
Hide resolved
southeo
reviewed
Oct 3, 2023
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/service/BioCaseService.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/DigitalObjectDirector.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/media/AccessRights.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/dissco/core/translator/terms/specimen/occurence/DataGeneralizations.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the new data model. Lots of new terms which are being harmonised to openDS from ABCD and DWC.
Includes:
Know issues:
Will also at some point go over all ABCD(EFG) terms and see if we missed any that could be mapped.
Will also at some point go over all DWC terms and see if we missed any