Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/opends 0.4.0 #63

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Feature/opends 0.4.0 #63

merged 6 commits into from
Nov 12, 2024

Conversation

samleeflang
Copy link
Collaborator

  • Update models to openDS 0.4.0
  • Add correct agents to prov

@samleeflang samleeflang requested a review from southeo November 11, 2024 10:50
southeo
southeo reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧

src/main/java/eu/dissco/orchestration/backend/utils/AgentUtils.java Show resolved Hide resolved
src/main/java/eu/dissco/orchestration/backend/utils/ControllerUtils.java Outdated Show resolved Hide resolved
src/main/java/eu/dissco/orchestration/backend/utils/AgentUtils.java Outdated Show resolved Hide resolved
src/main/java/eu/dissco/orchestration/backend/utils/AgentUtils.java Outdated Show resolved Hide resolved
src/main/java/eu/dissco/orchestration/backend/utils/ControllerUtils.java Outdated Show resolved Hide resolved
src/main/java/eu/dissco/orchestration/backend/service/DataMappingService.java Outdated Show resolved Hide resolved
@samleeflang samleeflang requested a review from southeo November 12, 2024 08:20
southeo
southeo previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment not blocking
🐔

src/main/java/eu/dissco/orchestration/backend/utils/AgentUtils.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
77.27% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@samleeflang samleeflang merged commit 265943f into main Nov 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southeo southeo southeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samleeflang @southeo