Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mjr endpoint #70

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Add mjr endpoint #70

merged 6 commits into from
Nov 14, 2023

Conversation

southeo
Copy link
Contributor

@southeo southeo commented Nov 7, 2023 •
edited
Loading

  • Get MJR record by job id
  • Get paginated list of MJRs by creator (may filter by state (failed, scheduled, completed)

JIRA

@samleeflang samleeflang self-requested a review November 13, 2023 07:55
samleeflang
samleeflang reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Looking forward seeing this in the FE

src/main/java/eu/dissco/backend/controller/MasJobRecordController.java Show resolved Hide resolved
src/main/java/eu/dissco/backend/controller/MasJobRecordController.java Show resolved Hide resolved
src/main/java/eu/dissco/backend/service/MasJobRecordService.java Outdated Show resolved Hide resolved
@southeo
Merge remote-tracking branch 'origin/main' into feature/mas-job-contr…
0f76267 
…oller

# Conflicts:
#	src/main/java/eu/dissco/backend/domain/annotation/HasRoi.java
@southeo
code review
1555dab
@southeo southeo requested a review from samleeflang November 14, 2023 13:26
samleeflang
samleeflang previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.6% 97.6% Coverage
0.0% 0.0% Duplication

@southeo southeo requested a review from samleeflang November 14, 2023 15:49
@southeo southeo merged commit e9ac31f into main Nov 14, 2023
3 checks passed
@southeo southeo deleted the feature/mas-job-controller branch November 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samleeflang samleeflang samleeflang approved these changes

Assignees

@samleeflang samleeflang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@southeo @samleeflang