Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handle function #63

Closed
wants to merge 3 commits into from
Closed

add handle function #63

wants to merge 3 commits into from

Conversation

southeo
Copy link
Contributor

@southeo southeo commented Oct 24, 2023

Adds handle classes

Base automatically changed from feature/an-model to main October 24, 2023 10:59
samleeflang
samleeflang reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a couple things that can be removed as we won't do specimen. Also most examples/mock data is aimed at specimen

src/main/java/eu/dissco/backend/web/HandleComponent.java Outdated
getFutureResponse(response);
}

public void rollbackFromPhysId(List<String> physIds) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is stuff in here we don't need right?

src/test/java/eu/dissco/backend/utils/HandleUtils.java Outdated
"primarySpecimenObjectId": "https://geocollections.info/specimen/23602",
"normalisedPrimarySpecimenObjectId":"https://geocollections.info/specimen/23602",
"primarySpecimenObjectIdType": "Global",
"specimenHost": "https://ror.org/0443cwa12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like appropriate FDO requests.

pom.xml
@@ -58,6 +58,10 @@
<artifactId>snappy-java</artifactId>
<version>${snappy-java.version}</version>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yes I guess for the API call to the annotation processing service we use a different client (openfeign I believe). But that will be removed at some point and then this will be the only client.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.8% 79.8% Coverage
0.0% 0.0% Duplication

@southeo southeo closed this Oct 24, 2023
@southeo southeo deleted the feature/add-handle-logic branch November 23, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samleeflang samleeflang samleeflang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@southeo @samleeflang