use human readable type for responses #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samleeflang
previously approved these changes
Dec 2, 2024
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public enum FdoType { |
There was a problem hiding this comment.
Ok this list is final right? This is what we will use when we move to production
There was a problem hiding this comment.
those 2 things aren't the same 😆 It's what we'll use for production though
samleeflang
reviewed
Dec 2, 2024
| DATA_MAPPING("https://doi.org/21.T11148/ce794a6f4df42eb7e77e", "ods:DataMapping"), | ||
| @JsonProperty("https://doi.org/21.T11148/22e71a0015cbcfba8ffa") | ||
| @JsonAlias("ods:MachineAnnotationService") | ||
| MAS("https://doi.org/21.T11148/22e71a0015cbcfba8ffa", "ods:MachineAnnotationService"), |
There was a problem hiding this comment.
Sorry it should be this:
https://dtr-test.pidconsortium.net/#objects/21.T11148/a369e128df5ef31044d4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have 2 type fields:
@type, which is human-readableods:fdoType, which is a DOIFor the responses, we need to provide a type to adhere to jsonAPI standards.
We had some objects that returned fdo types, some that returned human-readable types. Now, we return the human readable for the type. this is because we have some response types (e.g.
digitalSpecimenVersions) that don't have an FDO profile.Jira - back end types should be consistent