Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

face recognition #89

Closed
wants to merge 2 commits into from
Closed

Conversation

Shaistaattar42
Copy link

@Shaistaattar42 Shaistaattar42 commented Oct 13, 2024

using computer vision

Description

Please include a summary of the changes and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # API issue

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Devasy23
Copy link
Owner

Hello @Shaistaattar42 , you forgot to include a description with your PR, please describe your changes.
Moreover you have used harcascade for face detection which is good at beginner level but our code already has been using advanced algorithms like ssd and mtcnn for for detection and alignment.

@Devasy23
Copy link
Owner

@puwun please take further care of this PR and close it if this doesn't move in direction aligned with our goal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants