Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code, add tests, and update dependencies #6

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

Devasy23
Copy link
Owner

@Devasy23 Devasy23 commented Mar 9, 2024

Description

This pull request merges the split-tests-mark-2 branch into main. The changes include splitting the test cases in test_face_cycle.py into smaller tests for each endpoint, creating a new file test_face_endpoints.py to separately test each endpoint, and removing deprecated code from various modules to improve performance and maintainability.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The changes have been tested by running the test suite and all tests pass. The new test cases in test_face_endpoints.py have been verified to correctly test each endpoint.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Devasy23 Devasy23 requested a review from devansh-shah-11 March 9, 2024 19:27
@Devasy23 Devasy23 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 9, 2024
@Devasy23 Devasy23 self-assigned this Mar 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.64%. Comparing base (dcff0d0) to head (a4913c6).
Report is 1 commits behind head on main.

Files Patch % Lines
testing/test_face_endpoints.py 96.92% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   87.03%   89.64%   +2.60%     
==========================================
  Files           5        6       +1     
  Lines         216      280      +64     
==========================================
+ Hits          188      251      +63     
- Misses         28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Devasy23 Devasy23 merged commit 91e83d1 into main Mar 9, 2024
4 checks passed
@Devasy23 Devasy23 deleted the split-tests-mark-2 branch March 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants