-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks and update requirements.txt #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from Senior Dev Bot
print(f"Request failed: {e}") | ||
response = requests.get(f"http://127.0.0.1:8000/read/{EmployeeCode}") | ||
print(f'Request failed: {e}') | ||
response = requests.get(f'http://127.0.0.1:8000/read/{EmployeeCode}') |
Check failure
Code scanning / CodeQL
Partial server-side request forgery
def Delete(EmployeeCode): | ||
# logger.info(employees) | ||
response = requests.delete(f"http://127.0.0.1:8000/delete/{EmployeeCode}") | ||
response = requests.delete(f'http://127.0.0.1:8000/delete/{EmployeeCode}') |
Check failure
Code scanning / CodeQL
Partial server-side request forgery
Quality Gate failedFailed conditions |
@@ -144,36 +148,36 @@ | |||
HTTPException: If the employee is not found. | |||
|
|||
""" | |||
logging.info(f"Display information for {EmployeeCode}") | |||
logging.debug(f'Display information for {EmployeeCode}') |
Check failure
Code scanning / CodeQL
Log Injection
try: | ||
logging.info(f"Start {EmployeeCode}") | ||
logging.debug(f'Start {EmployeeCode}') |
Check failure
Code scanning / CodeQL
Log Injection
@@ -193,54 +197,60 @@ | |||
HTTPException: If no data was updated during the update operation. | |||
HTTPException: If an internal server error occurs. | |||
""" | |||
logging.info(f"Updating for EmployeeCode: {EmployeeCode}") | |||
logging.debug(f'Updating for EmployeeCode: {EmployeeCode}') |
Check failure
Code scanning / CodeQL
Log Injection
pil_image.save(image_filename) | ||
logging.info(f"Image saved {Employee.Name}") | ||
logging.debug(f'Image saved {Employee.Name}') |
Check failure
Code scanning / CodeQL
Log Injection
) | ||
logging.info(f"Embedding created {Employee.Name}") | ||
logging.debug(f'Embedding created {Employee.Name}') |
Check failure
Code scanning / CodeQL
Log Injection
logging.info(f"Deleting for EmployeeCode: {EmployeeCode}") | ||
client.find_one_and_delete(collection, {"EmployeeCode": EmployeeCode}) | ||
logging.info('Deleting Employee') | ||
logging.debug(f'Deleting for EmployeeCode: {EmployeeCode}') |
Check failure
Code scanning / CodeQL
Log Injection
Quality Gate failedFailed conditions |
This pull request adds pre-commit hooks to the project and updates the requirements.txt file with additional dependencies.