add week0002.cs #70
Open
add week0002.cs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietlq
reviewed
Nov 11, 2016
| var pointer = new Cell(0, 0); | ||
|
|
||
| //Change direction points | ||
| var MinMin = new Cell(1, 0); |
There was a problem hiding this comment.
Rename:
MinMin => TopLeft
MinMax => TopRight
MaxMax => BottomRight
MaxMin => BottomLeft
vietlq
reviewed
Nov 11, 2016
| } | ||
|
|
||
|
|
||
| pointer += move; |
There was a problem hiding this comment.
You are mixing up Cell & Movement. Although the code works, this does not make much sense from design perspective. Maybe you can simplify your code.
vietlq
reviewed
Nov 11, 2016
|
|
||
| if (pointer.Equal(MinMin)) | ||
| { | ||
| move = new Cell(0, 1); |
vietlq
reviewed
Nov 11, 2016
| } | ||
| else if (pointer.Equal(MinMax)) | ||
| { | ||
| move = new Cell(1, 0); |
vietlq
reviewed
Nov 11, 2016
| { | ||
| MaxMax.X--; MaxMax.Y--; | ||
| } | ||
| move = new Cell(0, -1); |
vietlq
reviewed
Nov 11, 2016
| { | ||
| MaxMin.X--; MaxMin.Y++; | ||
| } | ||
| move = new Cell(-1, 0); |
vietlq
reviewed
Nov 11, 2016
|
|
||
| for (var i = 1; i <= m * n; i++) | ||
| { | ||
| array[(int)pointer.X][(int)pointer.Y] = i; |
There was a problem hiding this comment.
Here's confusion: In your case X represents row (vertical ordinate) and Y represents column (horizontal ordinate).
It is counter-intuitive and hard to read. I would suggest to swap X & Y so they carry default meaning: Y for row & X for column.
vietlq
requested changes
Nov 11, 2016
|
Thank you for your review, I will improve my code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submit week2