Swift Language #69
Open
Swift Language #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietlq
reviewed
Nov 11, 2016
|
|
||
| func generateMatrix(n: Int) -> [[Int]] { | ||
| var res = Array<[Int]>(repeating: Array<Int>(repeating: 0, count: n), count: n) | ||
| var k = 1, i = 0 |
There was a problem hiding this comment.
Please give some meaningful names to i, j & k.
vietlq
reviewed
Nov 11, 2016
| var k = 1, i = 0 | ||
| while k <= n * n { | ||
| var j = i | ||
| while j < n - i { |
There was a problem hiding this comment.
Clearly you are going to the right. Please add a comment before each while loop so people can easily understand your logic.
vietlq
requested changes
Nov 11, 2016
|
Hi @larrypham, thanks for submitting PR. Going forward, I would like you to submit 1 solution per 1 feature branch. Please avoid using For the next submissions, please follow the guide in the video: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.