Cpp #67
Open
Cpp #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read guest information from input files and print out duplicated information
Solution for week 4
vietlq
reviewed
Oct 30, 2016
| return (m_email < rhs.m_email); | ||
| } | ||
|
|
||
| friend std::ostream & operator<<(std::ostream &out, Participant input) |
There was a problem hiding this comment.
Inconsistent spacing:
operator< (
operator<<(
There was a problem hiding this comment.
If you treat this function as a friend, you don't need to keep its implementation inside the class. Recommended idiom for larger projects:
class A
{
int data;
public:
void print(std::ostream& ostr)
{
ostr << "Data: " << data;
}
};
std::ostream& operator<<(std::ostream& ostr, const A& a)
{
a.print(ostr);
return ostr;
}
There was a problem hiding this comment.
Also I generally don't recommend having friends in C++ ;)
vietlq
reviewed
Oct 30, 2016
| SortedParticipantList eventB; | ||
|
|
||
| // Get file names from command line | ||
| GetParticipantListFromFile(argv[1], eventA); |
vietlq
reviewed
Oct 30, 2016
|
|
||
| //------------------------------------------------------------------------------ | ||
|
|
||
| /** Get participant list from input file**/ |
There was a problem hiding this comment.
Better way to comment:
/**
* @brief: Get participant list from input file
*/
vietlq
reviewed
Oct 30, 2016
| //------------------------------------------------------------------------------ | ||
|
|
||
| /**Parse a line and add it to the participant list**/ | ||
| void ParseParticipantInformation(const std::string &line, SortedParticipantList |
There was a problem hiding this comment.
It's recommended to have function names start with lowercase.
vietlq
requested changes
Oct 30, 2016
vietlq
reviewed
Oct 30, 2016
| { | ||
|
|
||
| public: | ||
| Participant (std::string firstName, std::string lastName, std::string email) : |
There was a problem hiding this comment.
Inefficient: Use const references! const std::string&
vietlq
reviewed
Oct 30, 2016
| //Ignore the first line as title. | ||
| std::getline(inputStream, line); | ||
|
|
||
| const std::regex pattern("(\\w+),(\\w++),([A-z0-9._%+-]+@\\w+\\.\\w+)"); |
There was a problem hiding this comment.
Does this match names like O'Reilly or van Derks? I don't think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for week 4