Week4 hienhpss #51
Week4 hienhpss #51
Conversation
| @@ -0,0 +1,5 @@ | |||
| fname,lname,email | |||
There was a problem hiding this comment.
Remove this. You need to submit your code only.
| @@ -0,0 +1,5 @@ | |||
| fname,lname,email | |||
There was a problem hiding this comment.
Remove this. You need to submit your code only.
| @@ -0,0 +1,2 @@ | |||
| Bill Gates <[email protected]> | |||
There was a problem hiding this comment.
Remove this. You need to submit your code only.
| print('{:s} {:s} <{:s}>'.format(str(person['fname']),str(person['lname']),str(person['email']))) | ||
|
|
||
| if __name__ == "__main__": | ||
| week4_output() |
There was a problem hiding this comment.
Always have a new line at the end of your code files.
| @@ -0,0 +1,56 @@ | |||
| import csv | |||
| from csv import Dialect | |||
| m.update(i_enc) | ||
| return m.digest() | ||
|
|
||
| def week4_csv_to_dict(csv_rows): |
There was a problem hiding this comment.
Don't call it week4, give it some meaningful name.
| if source1[key]['fname'] == source2[key]['fname'] and source1[key]['lname'] == source2[key]['lname']: | ||
| yield(source1[key]) | ||
|
|
||
| def week4_output(): |
There was a problem hiding this comment.
Don't call it week4, give it some meaningful name.
| return result | ||
|
|
||
|
|
||
| def week4_match_sources(): |
There was a problem hiding this comment.
Don't call it week4, give it some meaningful name.
| yield(source1[key]) | ||
|
|
||
| def week4_output(): | ||
| '''Outout list of duplicate guests to file''' |
| def week4_match_sources(): | ||
| '''Match the 2 input file and return the people | ||
| who subscribe to both''' | ||
| file1 = sys.argv[1] |
There was a problem hiding this comment.
I would rather pass 2 file names to this function. Avoid accessing sys.argv to make this function reusable.
| for row in csv_reader: | ||
| yield(row) | ||
|
|
||
| def generate_md5(*args): |
There was a problem hiding this comment.
The condition says each guest has only a single email, so you don't need md5, right? Have a cup of tea and think about it.
| for key in set(source1.keys()): | ||
| if key in set(source2.keys()): | ||
| if source1[key]['fname'] == source2[key]['fname'] and source1[key]['lname'] == source2[key]['lname']: | ||
| yield(source1[key]) |
There was a problem hiding this comment.
Congrats! Finally you have a valid reason to use generators ;)
Week 4 solution