Remove dependency on js-client-sdk for React generated types #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajwootto
reviewed
Jul 3, 2024
| useVariable as originalUseVariable, | ||
| useVariableValue as originalUseVariableValue | ||
| useVariableValue as originalUseVariableValue, | ||
| DVCVariable, |
There was a problem hiding this comment.
do these have "DevCycle" equivalents? We should be importing DevCycleVariable if that exists
There was a problem hiding this comment.
i thought we had them too, but looks like the types are all still DVC___ currently
https://github.com/DevCycleHQ/js-sdks/blob/main/sdk/js/src/types.ts#L198
ajwootto
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.