Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit API error logs to only render for CLI use-cases, not for other callers #406

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: limit API error logs to only render for CLI use-cases, not for other callers #406

merged 1 commit into from
Jun 26, 2024

Conversation

kaushalkapasi
Copy link
Contributor

  • only logs API errors to stdout when the caller is the CLI
  • adds test to to diff function to verify the stdout output

@kaushalkapasi kaushalkapasi merged commit 088c977 into main Jun 26, 2024
1 check passed
@kaushalkapasi kaushalkapasi deleted the limit-error-logging-output branch June 26, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsalaber jsalaber jsalaber approved these changes

@ajwootto ajwootto ajwootto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalkapasi @ajwootto @jsalaber