Dvc 8568 variations update in variables create #309
Conversation
elliotCamblor
commented
Oct 2, 2023
•
elliotCamblor
commented
elliotCamblor
force-pushed
the
DVC-8568-variations-update-in-variables-create
branch
6 times, most recently
from
d4cc2e8 to
cb8e36d
Compare
elliotCamblor
force-pushed
the
DVC-8568-variations-update-in-variables-create
branch
from
cb8e36d to
cf05dc2
Compare
| @@ -100,7 +100,7 @@ $ npm install -g @devcycle/cli | |||
| $ dvc COMMAND | |||
| running command... | |||
| $ dvc (--version) | |||
| @devcycle/cli/5.11.1 linux-x64 node-v18.16.0 | |||
There was a problem hiding this comment.
are we supposed to be committing these changes? my env always generates them but i just delete them
There was a problem hiding this comment.
Im not sure lol, Its just in the readme so I dont think it particularly matters
src/commands/variables/create.ts
Outdated
| await variableListOptions.promptVariationValues(params as Variable) | ||
| await updateFeature(this.authToken, this.projectKey, feature.key, feature) | ||
| const message = `The variable was associated to the existing feature ${feature.key}. ` + | ||
| `Use "dvc feature get ${feature.key}" to see its details` |
There was a problem hiding this comment.
should be dvc features get --keys=${feature.key}, i don't think we support get <key> currently (although we should)
There was a problem hiding this comment.
also should we still output the variable result here as well as the success message? might be kind of awkward since we'd have to find the new variable in the result of updateFeature but i feel like it might be annoying to have to get the feature separately just to check if you made a typo or something
There was a problem hiding this comment.
tbh I dont really think outputting the full variable is that useful here. Adam suggested that this be the response and I think I agree with him. Checking for a type is pretty much the only use case (especially since the command doesnt support headless mode if youre creating a feature)
There was a problem hiding this comment.
I will change the command thats output though, good catch!
There was a problem hiding this comment.
makes sense, works for me!
elliotCamblor
force-pushed
the
DVC-8568-variations-update-in-variables-create
branch
2 times, most recently
from
b973651 to
53050f1
Compare
elliotCamblor
force-pushed
the
DVC-8568-variations-update-in-variables-create
branch
from
53050f1 to
2fa99cf
Compare
elliotCamblor
force-pushed
the
DVC-8568-variations-update-in-variables-create
branch
from
2fa99cf to
59bb792
Compare
elliotCamblor
deleted the
DVC-8568-variations-update-in-variables-create
branch
