Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow async saving of SharedPreferences #182

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rabiaq123
Copy link
Contributor

@rabiaq123 rabiaq123 commented Dec 14, 2023

  • remove redundant commit() call
    • commit() will apply changes to SharedPreferences synchronously which may cause slower performance

@rabiaq123
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@rabiaq123 rabiaq123 changed the title [TSO-6] fix: use apply() to allow async saving of SharedPreferences [TSO-6] fix: allow async saving of SharedPreferences Dec 14, 2023
@rabiaq123 rabiaq123 requested a review from a team December 14, 2023 22:25
@rabiaq123 rabiaq123 changed the title [TSO-6] fix: allow async saving of SharedPreferences fix: allow async saving of SharedPreferences Dec 15, 2023
@rabiaq123 rabiaq123 force-pushed the TSO-6-shared-prefs-errors branch from 9aa6f9f to 448fa5f Compare December 15, 2023 14:24
@rabiaq123 rabiaq123 merged commit 93a3b4f into main Dec 15, 2023
5 checks passed
@rabiaq123 rabiaq123 deleted the TSO-6-shared-prefs-errors branch December 15, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants