github workflows updated, small tests fixes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
force-pushed
the
OOP_update
branch
2 times, most recently
from
e62fec9
to
d653c2e
Compare
| instance = super(Date, cls).__new__(cls) | ||
| cls._instances[string] = instance | ||
| return instance | ||
| # If not, create a new instance |
There was a problem hiding this comment.
I understand your intention here. However, even if else is redundant here (since we have return above), it makes the code a little bit more readable in my opinion. What do you think?
There was a problem hiding this comment.
sure, It's not matter of live/death - yet I really like the "fast return" pattern, there are a lot of examples https://realpython.com/python-return-statement/#using-return-with-conditionals :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch incorporates matrix testing