Skip to content

Commit

Permalink
Fix Exit to OS button focus in Pause Menu
Browse files Browse the repository at this point in the history
  • Loading branch information
ngosang authored and Zeno- committed Feb 10, 2015
1 parent a704c04 commit dd2bb95
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/game.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,7 @@ static void show_pause_menu(GUIFormSpecMenu **cur_formspec,
LocalFormspecHandler *txt_dst = new LocalFormspecHandler("MT_PAUSE_MENU");

create_formspec_menu(cur_formspec, invmgr, gamedef, tsrc, device, fs_src, txt_dst, NULL);

(*cur_formspec)->setFocus(L"btn_continue");
(*cur_formspec)->doPause = true;
}

Expand Down
7 changes: 5 additions & 2 deletions src/guiFormSpecMenu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
m_form_src(fsrc),
m_text_dst(tdst),
m_formspec_version(0),
m_focused_element(L""),
m_font(NULL)
#ifdef __ANDROID__
,m_JavaDialogFieldName(L"")
Expand Down Expand Up @@ -1757,8 +1758,6 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
<<std::endl;
}



void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
{
/* useless to regenerate without a screensize */
Expand All @@ -1775,6 +1774,10 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
mydata.table_dyndata[tablename] = table->getDynamicData();
}

//set focus
if (!m_focused_element.empty())
mydata.focused_fieldname = m_focused_element;

//preserve focus
gui::IGUIElement *focused_element = Environment->getFocus();
if (focused_element && focused_element->getParent() == this) {
Expand Down
10 changes: 9 additions & 1 deletion src/guiFormSpecMenu.h
Original file line number Diff line number Diff line change
Expand Up @@ -246,13 +246,20 @@ class GUIFormSpecMenu : public GUIModalMenu
m_allowclose = value;
}

void lockSize(bool lock,v2u32 basescreensize=v2u32(0,0)) {
void lockSize(bool lock,v2u32 basescreensize=v2u32(0,0))
{
m_lock = lock;
m_lockscreensize = basescreensize;
}

void removeChildren();
void setInitialFocus();

void setFocus(std::wstring elementname)
{
m_focused_element = elementname;
}

/*
Remove and re-add (or reposition) stuff
*/
Expand Down Expand Up @@ -348,6 +355,7 @@ class GUIFormSpecMenu : public GUIModalMenu
IFormSource *m_form_src;
TextDest *m_text_dst;
unsigned int m_formspec_version;
std::wstring m_focused_element;

typedef struct {
bool explicit_size;
Expand Down

0 comments on commit dd2bb95

Please sign in to comment.