-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/des 2339 passing new data to datacite #1133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarosenb
requested changes
Nov 27, 2023
fnets
previously requested changes
Nov 28, 2023
jarosenb
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved merge conflicts and tweaked things so that .to_datacite_json()
can work without passing in a project. Tested and it works for all project types with and without passing a top-level project.
jarosenb
dismissed
fnets’s stale review
December 13, 2023 16:35
This change request has been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Update Metadata that is being passed to Datacite
(1) Send Project Title as titleType 'Subtitle'
(2) Send Project description as descriptionType 'Abstract'
(3) Send Award Title and Number from project level
PR Status:
Related Jira tickets:
Summary of Changes:
For all project types:
Testing Steps:
UI Photos:
Notes:
This should work with or without a facility.
There is a following up ticket that requires modal changes, then updated data to Datacite: DES-2603