Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/des 2339 passing new data to datacite #1133

Merged
merged 15 commits into from
Dec 13, 2023

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Nov 22, 2023

Overview:

Update Metadata that is being passed to Datacite
(1) Send Project Title as titleType 'Subtitle'

  "titles": [
{
  "title": "mission title"
},
{
  "title": "Vanessa Field Research",
  "titleType": "Subtitle"
}
],

(2) Send Project description as descriptionType 'Abstract'

 "descriptions": [
{
  "lang": "en-Us",
  "description": "mission description mission description mission description",
  "descriptionType": "Abstract"
},
{
  "lang": "en-Us",
  "description": "description asdf",
  "descriptionType": "Abstract"
}
],

(3) Send Award Title and Number from project level

"fundingReferences": [
   {
     "awardTitle": "test award",
     "awardNumber": "13245"
   }
],

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

For all project types:

  1. Pass project info to to_datacite_json.
  2. Include title, description, and award info to datacite metadata.
  3. Pass facility info using condition that takes NO facility into account.

Testing Steps:

  1. Create a new project or use an old project: (check that all 3 options work)
  • Re-publish
  • Amend
  • Version
  1. Go to DataCite Test (https://doi.test.datacite.org/repositories/tdl.tacc) check for updated data. (Password in Stache)

UI Photos:

Notes:

This should work with or without a facility.
There is a following up ticket that requires modal changes, then updated data to Datacite: DES-2603

fnets
fnets previously requested changes Nov 28, 2023
designsafe/apps/projects/models/agave/experimental.py Outdated Show resolved Hide resolved
Copy link
Member

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved merge conflicts and tweaked things so that .to_datacite_json() can work without passing in a project. Tested and it works for all project types with and without passing a top-level project.

@jarosenb jarosenb dismissed fnets’s stale review December 13, 2023 16:35

This change request has been addressed.

@jarosenb jarosenb merged commit 3e3b515 into main Dec 13, 2023
2 checks passed
@jarosenb jarosenb deleted the task/des-2339-passing-new-data-to-datacite branch December 13, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants