Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/DES-2618: Consistent user metadata across project types #1131

Closed
wants to merge 15 commits into from

Conversation

jarosenb
Copy link
Member

Overview:

Our representation of project users/authors is inconsistent across project types, which will cause issues when we try to migrate things onto Tapis V3. This PR makes the following changes to project/entity metadata, which will be reflected when entities are saved:

  • Add a users field to projects that contains the PI, co-PIs, and team members. This will drastically simplify name-based searches in the future.
  • All "publishable" entities (entities that can be assigned a DOI) now have an "authors" field that contains the first name/last name/email/institution for all users
  • Previously, the object key for storing usernames was sometimes user and sometimes name. Now the key is username universally.
  • Arrays of authors/data collectors are now sorted by their "order" attribute. We've fixed the underlying bug that was causing arrays to lose their ordering on serialization, so during the V3 migration we can deprecate the use of JSON attributes for keeping track of array order.

The metadata schema changes in this PR are a strict superset of the existing schema, so the current curation/pipeline operations will just ignore them until we need to use them.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Testing Steps:

UI Photos:

Notes:

@jarosenb jarosenb changed the base branch from main to task/DES-2616--add-institution-to-profile November 20, 2023 21:05
Base automatically changed from task/DES-2616--add-institution-to-profile to main December 13, 2023 15:49
@jarosenb jarosenb closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant