Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port : Confirmation prompt for project deletion #173

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Port : Confirmation prompt for project deletion #173

merged 3 commits into from
Oct 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Oct 10, 2024 •
edited
Loading

Description

  1. If a user tries to delete a project, they are prompted to confirm their choice, with an additional warning that child projects will also be deleted.
  2. Fixes links with href="#" being pushed to Vue router.

Addressed Issue

Port change: DependencyTrack/hyades#1358

Additional Details

Screenshot 2024-10-10 at 15 02 31

Checklist

@sahibamittal @Gepardgame
Confirmation prompt for project deletion
3594c53 
Co-Authored-By: Thomas Schauer-Köckeis <[email protected]>
@sahibamittal sahibamittal added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Oct 10, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Oct 10, 2024
@sahibamittal sahibamittal marked this pull request as ready for review October 10, 2024 14:03
@sahibamittal sahibamittal mentioned this pull request Oct 10, 2024
Open
2 tasks
@nscuro nscuro merged commit 90021f7 into main Oct 18, 2024
9 checks passed
@nscuro nscuro deleted the port-confirmation-prompt-for-project-deletion branch October 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sahibamittal @nscuro