Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Fix redundant ConfigProperty queries in BadgeResource #977

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Nov 22, 2024

Description

Fixes redundant ConfigProperty queries in BadgeResource.

If unauthenticated badge access is enabled, the same ConfigProperty was previously queried three times. Since badges are embedded in public places, it'd be beneficial if the respective resources avoided unnecessary work.

Addressed Issue

Port change DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal changed the title Fix redundant ConfigProperty queries in BadgeResource Port : Fix redundant ConfigProperty queries in BadgeResource Nov 22, 2024
@sahibamittal sahibamittal added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Nov 22, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Nov 22, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a86d5d6) 22247 18397 82.69%
Head commit (c875665) 22248 (+1) 18398 (+1) 82.70% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#977) 16 16 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 1ecde60 into main Nov 22, 2024
9 checks passed
@nscuro nscuro deleted the Fix-redundant-ConfigProperty-queries-in-BadgeResource branch November 22, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants