Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load plugins when init.and.exit is enabled #931

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 26, 2024

Description

Plugins are not (yet) required for init tasks and thus don't need to be loaded.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Sep 26, 2024
Plugins are not (yet) required for init tasks and thus don't need to be loaded.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro force-pushed the init-and-exit-skip-plugins branch from 63482d2 to c5d6534 Compare September 26, 2024 19:07
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 0.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a3d83f7) 21977 18161 82.64%
Head commit (c5d6534) 21981 (+4) 18161 (+0) 82.62% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#931) 4 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal
Copy link
Collaborator

Code coverage can be ignored here.

@sahibamittal sahibamittal merged commit ad2bce9 into main Oct 1, 2024
8 of 9 checks passed
@sahibamittal sahibamittal deleted the init-and-exit-skip-plugins branch October 1, 2024 14:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants