Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authors column failing to be mapped for /api/v1/component/project/{uuid} endpoint #929

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 26, 2024

Description

Fixes authors column failing to be mapped for /api/v1/component/project/{uuid} endpoint.

This is just a simple fix to resolve the issue. But really this logic should be moved to a JDBI DAO, which is where we maintain our SQL queries now.

Addressed Issue

Fixes DependencyTrack/hyades#1536

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…ect/{uuid}` endpoint

This is just a simple fix to resolve the issue. But really this logic should be moved to a JDBI DAO, which is where we maintain our SQL queries now.

Fixes DependencyTrack/hyades#1536

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Sep 26, 2024
@nscuro nscuro added this to the 5.6.0 milestone Sep 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9f61931) 21896 18080 82.57%
Head commit (220b315) 21899 (+3) 18083 (+3) 82.57% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#929) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit 816b742 into main Sep 27, 2024
9 checks passed
@sahibamittal sahibamittal deleted the issue-1536 branch September 27, 2024 08:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one component shown plus error on console when reading components from db
2 participants