Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jakarta EE and OpenAPI v3 #785

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Migrate to Jakarta EE and OpenAPI v3 #785

merged 8 commits into from
Jul 31, 2024

Conversation

mehab
Copy link
Collaborator

@mehab mehab commented Jul 18, 2024

Description

This PR backports changes from DependencyTrack/dependency-track#3726 and DependencyTrack/dependency-track#3730 into hyades-apiserver

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@mehab mehab requested review from nscuro and sahibamittal July 18, 2024 14:20
Signed-off-by: mehab <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Jul 22, 2024
@nscuro nscuro added this to the 5.6.0 milestone Jul 22, 2024
Copy link

codacy-production bot commented Jul 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 58.62% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5dd51ff) 20717 16964 81.88%
Head commit (ccefe56) 20722 (+5) 16970 (+6) 81.89% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#785) 29 17 58.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

sahibamittal
sahibamittal previously approved these changes Jul 30, 2024
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this daunting work @mehab, really much appreciated! 🙏

Found a few minor wrinkles, but overall looks good.

pom.xml Outdated Show resolved Hide resolved
src/main/resources/META-INF/persistence.xml Outdated Show resolved Hide resolved
src/main/resources/META-INF/persistence.xml Outdated Show resolved Hide resolved
@nscuro nscuro mentioned this pull request Jul 30, 2024
5 tasks
@mehab mehab requested review from nscuro and sahibamittal July 31, 2024 09:59
@nscuro nscuro changed the title Jakarta ee migration and swagger open api v3 migration Migrate to Jakarta EE and OpenAPI v3 Jul 31, 2024
@mehab mehab merged commit 4013284 into main Jul 31, 2024
8 of 9 checks passed
@mehab mehab deleted the jakarta-ee-migration branch July 31, 2024 11:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants