Fix missing argument list for DROP FUNCTION migrations
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CALC_SEVERITY` can exist with both 3, and 4 arguments, depending on when the system was first deployed. `CALC_SEVERITY` was updated to take an additional `"severity_override" VARCHAR` argument in 6845ea1#diff-8a05bac09ccef76206adca46106e47020121bc13254146fc287fd1279ddfad8a, but the previous version of the function was not dropped back then. This adds argument lists to all functions being dropped, to avoid ambiguity. Signed-off-by: nscuro <[email protected]>
VithikaS
approved these changes
Jun 20, 2024
|
The failing test is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes missing argument list for
DROP FUNCTIONmigrations.CALC_SEVERITYcan exist with both 3, and 4 arguments, depending on when the system was first deployed.CALC_SEVERITYwas updated to take an additional"severity_override" VARCHARargument in 6845ea1#diff-8a05bac09ccef76206adca46106e47020121bc13254146fc287fd1279ddfad8a, but the previous version of the function was not dropped back then.This adds argument lists to all functions being dropped, to avoid ambiguity.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly