Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Checkstyle for Jetty and DataNucleus Enhance run configs #657

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Apr 24, 2024

Description

Skips Checkstyle for Jetty and DataNucleus Enhance run configs.

These configs are used frequently in development workflows, so the additional delay caused by checkstyle quickly adds up.

Instead, introduce a dedicated Checkstyle run configuration for quickly testing if the code conforms to standards.

Also, remove legacy Jetty config and replace it with the previous Jetty with PostgreSQL config.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

These configs are used frequently in development workflows, so the additional delay caused by checkstyle quickly adds up.

Instead, introduce a dedicated `Checkstyle` run configuration for quickly testing if the code conforms to standards.

Also, remove legacy `Jetty` config and replace it with the previous `Jetty with PostgreSQL` config.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the dx Issues related to developer experience (DX) label Apr 24, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e1daf9a) 18010 14419 80.06%
Head commit (959ae15) 18010 (+0) 14412 (-7) 80.02% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#657) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit 59f3d70 into main Apr 24, 2024
10 checks passed
@sahibamittal sahibamittal deleted the dev-skip-checkstyle branch April 24, 2024 15:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dx Issues related to developer experience (DX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants