Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial license objects being returned by /api/v1/component for components with unresolved license #578

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 14, 2024

Description

Fixes partial license objects being returned by /api/v1/component for components with unresolved license.

This caused licenses to be displayed as unresolved in the UI, even though no resolved license exists at all.

Addressed Issue

N/A

Additional Details

Before:

Screenshot 2024-02-15 at 00 32 20

After:

Screenshot 2024-02-15 at 00 30 56

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…or components with unresolved license

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Feb 14, 2024
@nscuro nscuro added this to the 5.3.0 milestone Feb 14, 2024
@sahibamittal sahibamittal merged commit fc10adb into main Feb 15, 2024
6 checks passed
@sahibamittal sahibamittal deleted the fix-component-list-licenses branch February 15, 2024 11:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants