Migrate all tests to use Postgres testcontainers instead of H2 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
changed the title
Avoids having to deal with differences between Postgres and H2. Just adds friction considering the application will never run with H2 in production. Might even be faster since the same container is reused across all test methods in a class, whereas the previous H2 way would re-create the entire database for each test method. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
…euse Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches all tests to use Postgres testcontainers instead of H2.
Avoids having to deal with differences between Postgres and H2. Just adds friction considering the application will never run with H2 in production.
Addressed Issue
Contributes to DependencyTrack/hyades#1074
Additional Details
Test execution times in CI only get a minor hit of 3-5min. Containers are re-used across test classes such that container restarts and database migration executions are kept to a minimum.
During this switch, multiple tests started failing due to assumptions that are true for H2 not being true for PostgreSQL. This is a win in my books, as our tests will now be closer to what is running in production.
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly