Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policy bundle sync being trigger-able even though the feature is disabled #556

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 5, 2024

Description

Fixes vulnerability policy bundle sync being trigger-able even though the feature is disabled.

This would previously lead to situations where the sync workflow is created, but can't ever complete due to the sync task execution being skipped.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…disabled

This would previously lead to situations where the sync workflow is created, but can't ever complete due to the sync task execution being skipped.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Feb 5, 2024
@nscuro nscuro added this to the 5.3.0 milestone Feb 5, 2024
@VithikaS VithikaS merged commit 3a56609 into main Feb 6, 2024
6 checks passed
@VithikaS VithikaS deleted the fix-policy-bundle-sync-when-disabled branch February 6, 2024 12:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants