Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude h2 from pom #341

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Exclude h2 from pom #341

merged 3 commits into from
Oct 3, 2023

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Oct 2, 2023

Description

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

vithikashukla added 3 commits October 2, 2023 15:55
remove h2 dependency
5870203 
Signed-off-by: vithikashukla <[email protected]>
exclude h2 dependency from pom
56ceef0 
Signed-off-by: vithikashukla <[email protected]>
add h2 as test dependency
7fe2d34 
Signed-off-by: vithikashukla <[email protected]>
mehab
mehab approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mehab mehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VithikaS VithikaS merged commit 3285ca1 into main Oct 3, 2023
6 checks passed
@VithikaS VithikaS deleted the exclude-h2-from-pom branch October 3, 2023 09:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehab mehab mehab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VithikaS @mehab