Improve performance of ScanResult recording
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of... * fetching the entire record from the database for every incoming `ScanResult` * modifying it in Java, and * updating it in DB ... use a single SQL statement, and only fetch data when the modified record is in the desired state. Signed-off-by: nscuro <[email protected]>
VithikaS
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR slightly improves performance of
ScanResultrecording in theVULNERABILITYSCANtable.For each
ScanResultwe process successfully, we we update aVULNERABILITYSCANrecord in the database. This merely involves incrementing of some counters in the record (total received results, total scanner results, failed scanner results, ...).Instead of...
ScanResult... use a single SQL statement, and only fetch data when the modified record is in the desired state.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly