Changed input validation on login form to passive #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DependencyTrack#585 In BValidatedInputGroupFormInput mode of validation-provider will automatically fallback to default mode 'aggressive' if no mode is specified. Signed-off-by: Nikemare <[email protected]>
nscuro
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed input validation of login form to passive. Validation will be triggered only by form submit now (click on Login button). This prevents OIDC button from moving before click event occurs.
Addressed Issue
Fixes #585
Additional Details
In BValidatedInputGroupFormInput mode of validation-provider will automatically fallback to default mode 'aggressive' if no mode is specified. Validation mode can be specified in other forms as well now.
Checklist
- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly