Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2737 - Fulfil NTIA minimum requirements #3090

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Issue #2737 - Fulfil NTIA minimum requirements #3090

merged 10 commits into from
Nov 1, 2023

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented Oct 12, 2023 •
edited
Loading

Description

Addressed Issue

#2737

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@leec94
Copy link
Contributor Author

leec94 commented Oct 12, 2023

can't fork melbas fork (#2867) so im adding it here for debugging

@leec94
Copy link
Contributor Author

leec94 commented Oct 12, 2023

looks like the CI tests aren't running, do i have to change this to not be a draft to run them?

@leec94 leec94 marked this pull request as ready for review October 12, 2023 15:46
@nscuro
Copy link
Member

nscuro commented Oct 12, 2023

looks like the CI tests aren't running, do i have to change this to not be a draft to run them?

Workflows on PRs from first time contributors need approval from maintainers first 😅 Approved it just now!

@leec94 leec94 changed the title DRAFT: Issue #2737 - Fulfil NTIA minimum requirements (CL edits) Issue #2737 - Fulfil NTIA minimum requirements (CL edits) Oct 24, 2023
@leec94 leec94 changed the title Issue #2737 - Fulfil NTIA minimum requirements (CL edits) Issue #2737 - Fulfil NTIA minimum requirements Oct 24, 2023
@nscuro nscuro added this to the 4.10 milestone Oct 26, 2023
nscuro
nscuro approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leec94! 🚀

@nscuro nscuro merged commit c92336c into DependencyTrack:master Nov 1, 2023
7 checks passed
@nscuro nscuro mentioned this pull request Nov 6, 2023
Closed
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.
2 participants
@leec94 @nscuro