Timestamp for PersonImage #2413
Conversation
VirginiaDooley
force-pushed
the
hotfix/person-image-timestamp
branch
from
7f38c4d to
7728dff
Compare
VirginiaDooley
changed the title
VirginiaDooley
changed the title
| ) | ||
| modified = pi.modified | ||
| response = self.app.get(f"/person/{person.id}", user=self.user) | ||
| self.assertIn( |
There was a problem hiding this comment.
BST problems? I tried this again with freeze_time and also changed the migration update and created default to datetime.now(timezone.utc).isoformat() but got the same error.
There was a problem hiding this comment.
Is this working now? CI seems ok?
There was a problem hiding this comment.
No, I don't think so - it's a mismatch in the time.
There was a problem hiding this comment.
I've pushed a commit that fixes this, but I'm a little confused as to why we're not getting the right timezone back from pi.modified. In my understanding, the model should store the timezone and return local time, but maybe that's not how it works.
- Show the last updated timestamp for PersonImage - Test migration and template for PersonImage timestamps - Fix timezone
VirginiaDooley
force-pushed
the
hotfix/person-image-timestamp
branch
from
b1eaeab to
057af63
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This work
PersonImageto aTimeStampedModelPersonImageinstances.These changes will also lay the groundwork for a more straightforward approach to refactoring #2386