Handle newlines in the middle of a name #2107
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored with @Bekabyx
Closes #2106
While my initial fix was more of any improvement for this specific SOPN, in the process of review, @Bekabyx discovered it was actually
camelot
that is responsible for adding new lines. At her suggestion, I've moved the code to strip newlines from the SOPN earlier in the process, (we don't store addresses so as long as this is the case, this change does not post any issues, AFAIK) into the extract table step. I've updated tests to reflect this change to the process.Test locally by uploading the SOPN for https://candidates.democracyclub.org.uk/bulk_adding/sopn/local.west-lancashire.rural-south.2023-06-22/ and parse. Names should be formatted as expected.