add City of London ID requirements #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Nov 7, 2024
Comment on lines
+68
to
+73
| "local.city-of-london.*": { | ||
| "default": null | ||
| }, | ||
| "local.city-of-london-alder.*": { | ||
| "default": null | ||
| }, |
There was a problem hiding this comment.
My opening gambit here was to make this local.city-of-london* but that didn't match the -alder case.
Having looked at the regex soup in the matching rules, I decided to just double up here rather than try to modify it.
symroe
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
First job on this one is to fix this library. then I'll cut a release, upgrade all the apps that use it, and then I'll work out if there is anywhere else that is showing wrong info about ID requirements.